Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined variable on Windows if scope != user #392

Merged
merged 4 commits into from Jan 4, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Jan 4, 2024

No description provided.

@Guts Guts self-assigned this Jan 4, 2024
@Guts Guts added the bug Something isn't working label Jan 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5747f60) 71.29% compared to head (ba9d090) 71.28%.
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   71.29%   71.28%   -0.02%     
==========================================
  Files          43       43              
  Lines        2449     2448       -1     
  Branches      521      521              
==========================================
- Hits         1746     1745       -1     
  Misses        526      526              
  Partials      177      177              
Files Coverage Δ
qgis_deployment_toolbelt/utils/win32utils.py 68.65% <40.00%> (-0.47%) ⬇️

Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Guts Guts merged commit 8fb49e8 into main Jan 4, 2024
25 checks passed
@Guts Guts deleted the fix/undefined-variable-spotted-by-sonar-cloud branch January 4, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants