Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: job environment variables support linux #435

Merged
merged 5 commits into from Feb 23, 2024

Conversation

Guts
Copy link
Owner

@Guts Guts commented Feb 23, 2024

Supersedes #345

Closes #322

@Guts Guts force-pushed the feature/job-environment-variables-support-linux-final branch from 1a0975e to 944967c Compare February 23, 2024 15:22
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request jobs Scenarios and jobs quality Tests, project resiliency, etc. labels Feb 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 79.42857% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 71.13%. Comparing base (f01ff91) to head (944967c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   70.04%   71.13%   +1.08%     
==========================================
  Files          44       45       +1     
  Lines        2474     2633     +159     
  Branches      526      566      +40     
==========================================
+ Hits         1733     1873     +140     
- Misses        573      583      +10     
- Partials      168      177       +9     
Flag Coverage Δ
unittests 70.52% <77.71%> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...loyment_toolbelt/jobs/job_environment_variables.py 82.35% <73.68%> (+1.10%) ⬆️
qgis_deployment_toolbelt/utils/linux_utils.py 80.12% <80.12%> (ø)

... and 4 files with indirect coverage changes

@Guts Guts force-pushed the feature/job-environment-variables-support-linux-final branch from 944967c to 6f813c2 Compare February 23, 2024 15:38
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
9.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Guts Guts merged commit ebae704 into main Feb 23, 2024
25 of 26 checks passed
@Guts Guts deleted the feature/job-environment-variables-support-linux-final branch February 23, 2024 15:41
@Guts Guts removed the documentation Improvements or additions to documentation label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jobs Scenarios and jobs quality Tests, project resiliency, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Allow environment variable management under Linux
3 participants