Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(env variable): update local environment #455

Merged
merged 1 commit into from Apr 2, 2024

Conversation

jmkerloch
Copy link
Collaborator

closes #451

Local python environment variable was not updated by manage-env-vars job.

The added/removed variable could not be resolved when reading/writing .ini files.

@jmkerloch jmkerloch self-assigned this Mar 26, 2024
@jmkerloch jmkerloch requested a review from Guts March 26, 2024 08:17
@jmkerloch jmkerloch added the bug Something isn't working label Mar 26, 2024
@github-actions github-actions bot added the jobs Scenarios and jobs label Mar 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.82%. Comparing base (69ab595) to head (5257192).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   71.78%   71.82%   +0.03%     
==========================================
  Files          45       45              
  Lines        2715     2722       +7     
  Branches      587      588       +1     
==========================================
+ Hits         1949     1955       +6     
  Misses        582      582              
- Partials      184      185       +1     
Flag Coverage Δ
unittests 71.30% <85.71%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...loyment_toolbelt/jobs/job_environment_variables.py 83.05% <85.71%> (+0.35%) ⬆️

@jmkerloch jmkerloch force-pushed the fix/env_variable_in_qdt_jobs branch 2 times, most recently from eb6d800 to 0b530a5 Compare March 28, 2024 14:11
@Guts Guts force-pushed the fix/env_variable_in_qdt_jobs branch from 0b530a5 to 5257192 Compare March 29, 2024 19:50
@Guts Guts force-pushed the fix/env_variable_in_qdt_jobs branch from 5257192 to 7b7edd6 Compare April 2, 2024 11:05
Copy link
Owner

@Guts Guts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀!

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jmkerloch jmkerloch merged commit b3ac329 into main Apr 2, 2024
25 checks passed
@jmkerloch jmkerloch deleted the fix/env_variable_in_qdt_jobs branch April 2, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working jobs Scenarios and jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Interpolation in INI file is not working as expected
3 participants