Torrent file does not download

[grinn]

I've yet to find where the Torrent file downloaded. I've looked in my Downloads folder, in the data folder suggested in Issue #30, and even used File Manager to search my entire disk for any torrent files, at no avail.

When downloading, it displays the notification that it was successful. I'm running on an LG G3 with no SD card.

[Twinklebear]

Strange, they should show up somewhere on the device at least. I think this will probably be fixed when #30 is resolved and you can specify your own download path. Since we write to external storage in the fix for #30 I'm not sure if a missing SD card would be an issue, since the "external" storage can also just be the phone's internal storage emulating external storage, but I suppose if it is a problem there's a fix to catch that which shouldn't be too bad.

I hope to get the update out next week, could you let me know how it works when you get a chance to try it out?

[grinn]

Ahh, I didn't realize that you guys changed it to the SD card with #30. I'm sure that's it and will be happy to try it again with the next build. Nice UI, by the way.

[Twinklebear]

This should be fixed in the latest release by bfe7a6f, let me know if it works and I'll close this issue 😄.

[grinn]

It worked, but was buggy. I sent a crash report but the gist of it is this:

• The path you give is (unexpectedly) relative to your download folder.
• If you start the path with a slash, the app crashes.
• If I don't provide a path, it does not download the file (which I assume
  means it's pointing to the SD Card path).
• Setting the path to "/" appears to be the only way to download directly
  to the downloads folder but of course this causes the app to crash when
  setting it.

I would suggest that the default path be the user's default download
directory, and let folks alter that in their phone's settings or provide a
different path here if they want it on their SD card - but that's just me.
Also, for your audience having to type the full path is probably ok, since
we're all at least power users - but a dialog to select the path would be
an improvement for the UX.

• Denny Caldwell

On Sun, Oct 12, 2014 at 8:19 PM, Will Usher notifications@github.com
wrote:

This should be fixed in the latest release
https://github.com/Gwindow/WhatAndroid/releases/tag/2.1.1.b by bfe7a6f
bfe7a6f,
let me know if it works and I'll close this issue [image: 😄].

—
Reply to this email directly or view it on GitHub
#31 (comment).

[Twinklebear]

The crash I think is from a semi-related bug I introduced when setting up the preference changed listener to test that we can create the folder selected (based on the crash report you sent) that I've got a fix in place for on develop. I'll probably put this out after making some tweaks to how the path preference behaves, hopefully soonish though since the bug is pretty easy to trigger.

I agree it may be best to just default to placing downloads under the public downloads folder instead of wherever the Download Manager sends them so that they're easily accessible, I'll look into making this the default behavior. Currently if you don't provide a path the files go wherever the Download Manager sends them (which often seems to be a black hole).

I'm thinking about changing the preference so that if you don't start the path with a "/" files will be placed under the path specified in your downloads folder but if you do start the path with a "/" they'll be placed under that absolute path (eg. relative to your root directory). This might be a bit more complicated to explain in the preference text but should give the best of both options so folks who just want a sub-directory under Downloads can get it easily and folks who want to place it anywhere can also do so by specifying the absolute path to where they want files.

A dialog to pick the absolute path could be pretty useful although I'll need to do some reading to figure out how to implement it.

[Twinklebear]

The latest release has a directory picker now instead of text input to select the download directory, I think this should hopefully resolve the various issues with picking the directory via text input. Let me know what you think 😄

[grinn]

Yep. That did the trick!

• Denny Caldwell

On Sat, Nov 22, 2014 at 10:57 PM, Will Usher notifications@github.com
wrote:

The latest release has a directory picker now instead of text input to
select the download directory, I think this should hopefully resolve the
various issues with picking the directory via text input. Let me know what
you think [image: 😄]

—
Reply to this email directly or view it on GitHub
#31 (comment).

[Twinklebear]

Awesome! 😃