Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaterialSearch close icon has MouseDownHandler instead of ClickHandler #926

Closed
chamgda opened this issue Jul 22, 2019 · 2 comments · Fixed by #971 or #976
Closed

MaterialSearch close icon has MouseDownHandler instead of ClickHandler #926

chamgda opened this issue Jul 22, 2019 · 2 comments · Fixed by #971 or #976
Assignees
@kevzlou7979
Labels
bug
Milestone
Release 2.3.1

Comments

@chamgda
Copy link

chamgda commented Jul 22, 2019

MaterialSearch adds a MouseDownHandler on the close icon instead of a click handler for whatever reason. This makes its behaviour inconsistent with other controls and also makes it harder to make the widget keyboard controllable (can't just call click() on the element as you can when the element has a ClickHandler).
@kevzlou7979
Copy link
Contributor

Will revalidate this and will patch on GMD 2.3

@kevzlou7979 kevzlou7979 self-assigned this Sep 5, 2019
@kevzlou7979 kevzlou7979 added the bug label Sep 5, 2019
@kevzlou7979 kevzlou7979 added this to the Release 2.3 milestone Sep 5, 2019
kevzlou7979 added a commit that referenced this issue Apr 24, 2020
@kevzlou7979
Fixed #926
52c1a7a
@kevzlou7979
Copy link
Contributor

Fixed 52c1a7a

@kevzlou7979 kevzlou7979 modified the milestone: Release 2.3.1 Apr 24, 2020
@kevzlou7979 kevzlou7979 mentioned this issue Jul 24, 2020
Merged
@kevzlou7979 kevzlou7979 mentioned this issue Aug 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevzlou7979 kevzlou7979

Labels
bug
Projects
None yet
Milestone
Release 2.3.1
2 participants
@kevzlou7979 @chamgda