You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The "gwt-CheckBox" styleclass was still being applied to the main div element of a CheckBox in version 2.1.1. In v2.2, the class is missing, which breaks some of our css stylesheets.
I believe the issue was introduced in this commit: c4c7dda
As you can see, the style class used to be applied immediately in the constructor of BaseCheckBox, but that line was removed. Now, the code appears to rely on MaterialWidget setting the class as one of the initialClasses in the onLoad method. However, BaseCheckBox overrides onLoad and does not call super.onLoad in turn, so the MaterialWidget implementation of onLoad never runs for BaseCheckBox instances (possibly a bug in its own right, but I don't know the code well enough to judge that), and thus the gwt-CheckBox initalClass is never set.
The text was updated successfully, but these errors were encountered:
Seen in GwtMaterialDesign 2.2
The "gwt-CheckBox" styleclass was still being applied to the main div element of a CheckBox in version 2.1.1. In v2.2, the class is missing, which breaks some of our css stylesheets.
I believe the issue was introduced in this commit:
c4c7dda
As you can see, the style class used to be applied immediately in the constructor of BaseCheckBox, but that line was removed. Now, the code appears to rely on MaterialWidget setting the class as one of the initialClasses in the onLoad method. However, BaseCheckBox overrides onLoad and does not call super.onLoad in turn, so the MaterialWidget implementation of onLoad never runs for BaseCheckBox instances (possibly a bug in its own right, but I don't know the code well enough to judge that), and thus the gwt-CheckBox initalClass is never set.
The text was updated successfully, but these errors were encountered: