Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterialCheckBox no longer applies gwt-CheckBox class #973

Closed
Medo42 opened this issue Aug 5, 2020 · 3 comments
Closed

MaterialCheckBox no longer applies gwt-CheckBox class #973

Medo42 opened this issue Aug 5, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@Medo42
Copy link
Contributor

Medo42 commented Aug 5, 2020

Seen in GwtMaterialDesign 2.2

The "gwt-CheckBox" styleclass was still being applied to the main div element of a CheckBox in version 2.1.1. In v2.2, the class is missing, which breaks some of our css stylesheets.

I believe the issue was introduced in this commit:
c4c7dda

As you can see, the style class used to be applied immediately in the constructor of BaseCheckBox, but that line was removed. Now, the code appears to rely on MaterialWidget setting the class as one of the initialClasses in the onLoad method. However, BaseCheckBox overrides onLoad and does not call super.onLoad in turn, so the MaterialWidget implementation of onLoad never runs for BaseCheckBox instances (possibly a bug in its own right, but I don't know the code well enough to judge that), and thus the gwt-CheckBox initalClass is never set.

@kevzlou7979
Copy link
Contributor

Will try to reproduce first thing tomorrow.

@kevzlou7979 kevzlou7979 added this to the Release 2.4.1 milestone Aug 10, 2020
@kevzlou7979 kevzlou7979 self-assigned this Aug 10, 2020
@kevzlou7979
Copy link
Contributor

image

kevzlou7979 added a commit that referenced this issue Aug 10, 2020
@kevzlou7979
Copy link
Contributor

kevzlou7979 commented Aug 10, 2020

Fixed via 0978e2b. Will be available this coming 2.4.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants