Fix playback for unmuted videos getting blocked by browser autoplay policies #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gyanreyer
force-pushed
the
fix/fix-playback-with-audio-being-blocked
branch
2 times, most recently
from
123bd55
to
8c7c9a1
Compare
Codecov Report
@@ Coverage Diff @@
## main #65 +/- ##
===========================================
- Coverage 100.00% 99.65% -0.35%
===========================================
Files 9 9
Lines 281 290 +9
Branches 113 114 +1
===========================================
+ Hits 281 289 +8
- Misses 0 1 +1
Continue to review full report at Codecov.
|
Gyanreyer
force-pushed
the
fix/fix-playback-with-audio-being-blocked
branch
from
8c7c9a1
to
e41c6ce
Compare
…d by browser autoplay policies If the browser blocks an unmuted video from playing, we will mute the video, attempt to play again, and restore sound once the user has clicked on the page. re #64
Gyanreyer
force-pushed
the
fix/fix-playback-with-audio-being-blocked
branch
from
e41c6ce
to
1a2d2b0
Compare
…rs block playback with audio
Gyanreyer
changed the title
|
🎉 This PR is included in version 9.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where unmuted videos could get blocked from playing by browsers' autoplay policies. This issue arose because browser policies require the user to have "interacted" with the page before playing a video with audio, and hover events don't count as a valid interaction; the user needs to click the page.
To get around this issue, if the browser blocks an unmuted video from playing, we will mute the video, attempt to play again,
and then restore sound once the user has clicked on the page.
re #64
Changes