Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window too large on Debian Sid in X11 #344

Closed
1 task done
tripplehelix opened this issue Aug 17, 2023 · 16 comments · Fixed by #365
Closed
1 task done

Window too large on Debian Sid in X11 #344

tripplehelix opened this issue Aug 17, 2023 · 16 comments · Fixed by #365
Labels
bug Something isn't working
Milestone

Comments

@tripplehelix
Copy link

Is there an existing issue for this?

  • I have searched the existing issues.

What's the problem?

I have both installed the provided deb and built from source from this repo. In both cases the window opens larger than my screen resolution. Only able to resize vertically slightly. This makes the app unusable.

Operating System: Debian GNU/Linux trixie/sid
Desktop Environment: Xfce 4.18
Build Version: 1.2.2

How did you install the app?

built locally by cloning the repository

Operating System

Linux

Additional context

image

@GyulyVGC
Copy link
Owner

Thanks for the report.
What's your screen resolution?

@GyulyVGC GyulyVGC added the bug Something isn't working label Aug 18, 2023
@GyulyVGC GyulyVGC added this to the v1.3.0 milestone Aug 18, 2023
@GyulyVGC
Copy link
Owner

This is also somewhat related to #202, even if not the same issue.
To solve this issue, it'll be necessary to reduce the minimum window size allowed and some widgets won't have enough space, but this additional problem will be solved by defining a lower scale factor as described in #202
I'll take care of solving both issues before v1.3 is published.

@tripplehelix
Copy link
Author

Thanks for the report. What's your screen resolution?

1920x1080

@GyulyVGC
Copy link
Owner

GyulyVGC commented Aug 18, 2023

Mmm weird... I've tried Sniffnet in PCs with lower resolutions and everything was fine.
The minimum size currently allowed for the window is 1190x610, but that are logical pixels and not physical ones.
So it depends on how that are converted to physical pixels in your specific case (source).

I think that introducing a custom scale factor will resolve this issue as well.

@GyulyVGC
Copy link
Owner

@tripplehelix can you try building from this branch and let me know if by lowering the scale factor the issue is solved?
You can change the scale factor from the application settings (top right corner of the app) in the rightmost tab (advanced settings).

@tripplehelix
Copy link
Author

Incredibly difficult getting to the settings with the window so large, this is minimum scale factor and I've dragged the window as small as possible.

image

@GyulyVGC
Copy link
Owner

I've just adjusted the minimum size allowed for the window in that same branch, meaning that now you should be able to resize the window to fit your screen.

The default window size is kept the same and immediately after the start it is maximised.
I'm curious if the maximise operation immediately adapts the window size to your screen after start, so that you don't have to manually resize it every time.

Let me know when you can.

@tripplehelix
Copy link
Author

tripplehelix commented Aug 23, 2023

I've just adjusted the minimum size allowed for the window in that same branch, meaning that now you should be able to resize the window to fit your screen.

The default window size is kept the same and immediately after the start it is maximised. I'm curious if the maximise operation immediately adapts the window size to your screen after start, so that you don't have to manually resize it every time.

Let me know when you can.

Ok, that works, but the window is double the size it needs to be. By default it opens full screen.

With scale factor of 0.5 text and icons look a normal size.

Screenshot_2023-08-23_14-41-43
Ignore the error

@tripplehelix
Copy link
Author

When you un-pin it from full screen it pops to larger than screen resolution.

@GyulyVGC
Copy link
Owner

Ok, that works, but the window is double the size it needs to be. By default it opens full screen.

So, when you open the app the dimension exactly fits your screen?
What do you mean by the size is double? I'm assuming you mean the scale factor, right?

Screenshot_2023-08-23_14-41-43

And this is the situation after you resize it to the minimum, right?

@tripplehelix
Copy link
Author

Ok, that works, but the window is double the size it needs to be. By default it opens full screen.

So, when you open the app the dimension exactly fits your screen? What do you mean by the size is double? I'm assuming you mean the scale factor, right?

Screenshot_2023-08-23_14-41-43

And this is the situation after you resize it to the minimum, right?

For me, the window size should be half what its minimum is currently. Yes, that is the minimum size of the window.

When I first open the application it perfectly fits my resolution yes, but enlarges when unpinned.

Scale factor is only fine when set to 0.5 so in my situation this should be default on first install.

@tripplehelix
Copy link
Author

Here is a comparison between sniffnet and an application built for the OS

image

@GyulyVGC
Copy link
Owner

It enlarges when unpinned because it switches back to the default size.

After you set the desired scale factor, it should be remembered by the application on the following restarts.

For what concerns even smaller dimensions for your specific use case, even allowing smaller dimensions I doubt that you'd see all the information properly displayed on the screen (charts, connections, and all the other stuff).
What I mean is that Sniffnet has not been thought to be responsive to the extent of reaching the dimension of your "tom - Thunar" window.
Furthermore, resizing the window to extra small values was reported to cause a crash in #12.

Let me know your thoughts, if you think all the information could be properly displayed even for smaller windows, the minimum size can be lowered even more.

@tripplehelix
Copy link
Author

I don't believe it all needs to be displayed at once, for example if I am using it to find an erroneous app I'd place the app in a corner of my screen at 1/4th the resolution and scroll around the application to the relevant place. Using the rest of the screen for the terminal, application in question and maybe even the file explorer. Currently the apps seems to want to be the main focus all the time when using it. Also, what if my screen resolution was even smaller? The window would still display over the edges of the screen.

Why does the app not pull it's text size from the OS?

@GyulyVGC
Copy link
Owner

Why does the app not pull it's text size from the OS?

The GUI library in use doesn't provide this functionality.

I'm used to keep apps I don't want to be the focus on the background, or on a different desktop.
That's basically why Sniffnet is not thought to be configured for a "pop-up" mode.
This is a feature it could be worked on though...

@GyulyVGC GyulyVGC linked a pull request Sep 2, 2023 that will close this issue
@GyulyVGC
Copy link
Owner

@tripplehelix hey, the changes we discussed have just been merged to the main branch (implemented as part of #365).

These and other features will be officially released in version 1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants