Expose xcb_im_feedback_t #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This looks fine to me, except for some missing documentation. Please add some docs to the introduced constants. I will merge this then! |
|
I added docs. Please check it. I am not good at English. |
wez
added a commit
to wez/wezterm
that referenced
this pull request
Jan 24, 2024
My branch includes my own fixes, as well as this PR: refs: H-M-H/xcb-imdkit-rs#3 which should enable this PR that's been blocked on it for a while: refs: #2056
|
I've merged this PR into my fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constants are necessary for getting information from feedback_array.