Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault node text columns are too short for long KI text notes #174

Open
dgelessus opened this issue Feb 7, 2023 · 0 comments
Open

Vault node text columns are too short for long KI text notes #174

dgelessus opened this issue Feb 7, 2023 · 0 comments

Comments

@dgelessus
Copy link
Contributor

DIRTSAND declares the vault node Text_1/Text_2 columns as character varying(1024), but the client allows KI text notes to be (roughly) 2048 characters long.

This means that a player with a regular client can type a moderately long KI text note that DIRTSAND is unable to save. When that happens, the player has no indication that anything went wrong - the client accepts the text and caches it locally, but the server silently fails to save it to the vault. The player can only notice the problem after the client re-fetches the vault node from the server, i. e. after logging out and back in.

The only indication of the error is a log message on the server side:

.../dirtsand/AuthServ/AuthVault.cpp:1005:
    Postgres UPDATE error: ERROR:  value too long for type character varying(1024)

The same problem also applies to the neighborhood description text, which is also stored in Text_1 and AFAICT has no client-side limit at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant