Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewFaceMod Changes #214

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ViewFaceMod Changes #214

wants to merge 2 commits into from

Conversation

TikiBear
Copy link
Contributor

@TikiBear TikiBear commented Oct 3, 2020

Add offsets and pivots to the swivel interface. Requires update to UI render.py.

Add offsets and pivots to the swivel interface. Requires update to UI render.py.
@Hoikas
Copy link
Member

Hoikas commented Oct 3, 2020

Thanks for the pull request, @TikiBear! I am asking @Deledrius to take a look at these changes because he was the original author of the swivel modifier, and I don't feel comfortable enough to make any judgement calls around its behavior. I just pick the pythonic nits in those cases 😄

@TikiBear
Copy link
Contributor Author

TikiBear commented Oct 4, 2020 via email

Add flag to expose missing pivots to swivel interface. Requires update to the Modifiers render.py.
@Hoikas Hoikas mentioned this pull request Apr 26, 2021
@Hoikas Hoikas changed the title Update render.py ViewFaceMod Changes Apr 26, 2021
@Deledrius
Copy link
Member

I'm not quite understanding what this fixes. Can you explain (perhaps with one or more illustrations)? Adding this option seems reasonable, but I'd like to know what the use-case is that you are seeing it applies to.

@TikiBear
Copy link
Contributor Author

In the Sprite Gallery in DI or UAM:

I use the local offset feature to have imagers face the screen rather than the camera. This also enables the avatar to walk through the image without encountering an axis-crossing singularity. You can't really demonstrate the absence of singularities in still pictures, though. There are three imagers visible in [Imagers.jpg].

I use the global offset feature to keep each sconce's nimbus from intersecting the wall in the disco. [SconceFar.jpg, SconceClose.jpg]

I use the 3-axis pivot for the main lamps. The 3-axis pivot has no axis-crossing singularity. All other pivots have them (though note above scenario). [MainLamp.jpg]

The disco ball nimbus uses the 3-axis pivot for the above plus it rotates along with the disco ball. If you look up at the ball it rotates clockwise and so does the nimbus. If you look down the ball rotates counter-clockwise and so does the nimbus. Don't ask me to explain the geometry. I haven't figured it out, yet. [DiscoBall.jpg]

I acknowledge that I can't see a difference between the 2-axis on Z and 2-axis on Y pivots in-game. In the Blender (or other tool) files the nimbus must face along the azimuthal axis of 2-axis on Z pivots. For the 2-axis on Y pivots that's not the case. I would prefer to see them "looking up" in the Blender file. So, my guess is that the 2-axis on Y pivot is more for design than deployment.

Link to image folder: https://app.box.com/s/ocurcdqbe1oxxf5db8m09mzx1od0az5e

@Deledrius
Copy link
Member

Thanks for the additional explanation. I tried to model the existing system closely on the presentation available in the 3DS Max plugin, and then streamlined it from there to highlight the typical use cases. This particular modifier is a bit of a strange one to wrap the brain around behind-the-scenes.

@TikiBear
Copy link
Contributor Author

It isn't very intuitive. It was only after making and seeing the various scenarios that I understood the possibilities the features create.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants