Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Imager Modifier #348

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Imager Modifier #348

wants to merge 4 commits into from

Conversation

DoobesURU
Copy link
Contributor

A potential Imager Modifier for Korman. Could eventually be used in a future Plasma premade object.

Everything appears to be working, but input on UI layout and any potential "gotchas" in properties I may have missed is certainly welcome.

@DoobesURU
Copy link
Contributor Author

Also not really sure if we want to expose some parts of the script such as the Inbox SDL variable, pellet score, members only, etc. or keep things more simple, so some feedback on that would also be appreciated.

@DoobesURU
Copy link
Contributor Author

Thinking I might also add a type of imager selector (postable or visitor) after the object, material, and texture are chosen to make the latter a bit more simple. For the latter though, would it be possible and prudent to add the extra Python scripting for a visitor imager to the Age's py file automatically or just leave that up to the user to do manually?

@Hoikas
Copy link
Member

Hoikas commented Feb 28, 2023

I'm going to continue to defer on this because imagers in general are a bit fiddly on the Python side. You've exposed a lot of things, for example the visitor imager, but every Age that implements one of those has a set of copy-pasta'd Python code to actually update the imager. Ideally, we will rewrite xSimpleImager.py in the game to not be a steaming pile of 💩 and include the ability to update the imager as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants