Improve vertex color exporting significantly. #396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 15, 2024
This moves the piece-by-piece assembly of vertex colors from `_export_geometry()` into a one-stop-shop for getting the near final vertex colors as Blender knows them. Included in this is separating out the adjustment channels for wavesets - which are stuffed inside of vertex colors. It is now an error for a waveset to have a "col", "color", or "colour" vertex color layer. This is to prevent confusion. Wavesets now accept alpha (red), specularity (green), fresnel (blue), and edgelength (alpha) vertex color layers. The color values in these layers is averaged and output to the respective channels. Further, a default value for edgelength is now computed similar (but not exactly like) PlasmaMax's `SetWaterColor()` function. Artist input to the edgelength vertex color layer will modulate Korman's calculation.
Hoikas
force-pushed
the
mesh_improvements
branch
from
a3893eb
to
ec633db
Compare
This means that we gather up the UVs for every vertex in a temporary tuple of tuples at the beginning of the export process. That's more memory intensive, but it removes quite a bit of fiddling in the tighter inner loops, so it's an overall win.
timeit indicates that this is a 43% improvement in performance.
|
At the moment, it appears to not only eat the textures, but we also have some sort of checker pattern on everything: |
|
Can you share a screenshot with the results before this PR? |
|
|
This PR is almost completely wrong and needs to be revised significantly. |
|
Closing in favor of rewriting the entire mesh converter, someday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the piece-by-piece assembly of vertex colors from
_export_geometry()into a one-stop-shop for getting the near final vertex colors as Blender knows them. Included in this is separating out the adjustment channels for wavesets - which are stuffed inside of vertex colors. It is now an error for a waveset to have a "col", "color", or "colour" vertex color layer. This is to prevent confusion. Wavesets now accept alpha (red), specularity (green), fresnel (blue), and edgelength (alpha) vertex color layers. The color values in these layers is averaged and output to the respective channels. Further, a default value for edgelength is now computed similar (but not exactly like) PlasmaMax'sSetWaterColor()function. Artist input to the edgelength vertex color layer will modulate Korman's calculation.CC @DoobesURU to verify nothing breaks and that waveset vertex alpha should now function as expected.
This is still a draft because I would like to do a pass over eliminating list comprehensions in the tight inner loop of
_export_geometry(). Until Python 3.12, list comprehensions are actually implemented as function calls. I see 1 comprehension for every face and 1 comprehension for every vertex (!!!), which are major targets for performance optimization.