-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize PFM Stub Storage and Add the SDL Show/Hide Modifier. #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0d100d
to
deb8e89
Compare
This helps make Korman more maintainable by reducing potential duplication of Python attribute definitions. Further, it simplifies the code to create a Python File Node for a standard API file.
Logic trees can be shared, so it is conceivable that a logic tree might be pre-exported more than once. They can already be created by artists and referenced from multiple Advanced Logic modifiers, so this is good for consistency.
So I slapped some show/hide SDL mods on a few objects. The Boolean SDL show/hide mods in Chiso seemed to work just fine. However, the Integer show/hide mods in the Pub came back with this error:
|
New error after commit d19534b:
|
This adds a modifier for the very common PythonFileMods xAgeSDLBoolShowHude and xAgeSDLIntShowHide. Right now, Korman doesn't try to parse SDL files, so the variable name and type have to be specified manually. The benefit to this, however, is the ability to easily wire up global SDL visibility type features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This centralizes the location of all PFM attribute stubs for easier maintenance and adds a modifier exposing xAgeSDLBoolShowHide and xAgeSDLIntShowHide. It should hopefully make life a little easier for creating global SDL controlled visibility type stuff.