Round firemarbles #71
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoikas
added
conflict
|
Conflicts with #65 |
Relto [Generic Physical - MarblePhy06] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" [Generic Physical - MarblePhy07] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" [Generic Physical - MarblePhy08] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" [Generic Physical - MarblePhy09] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" [Generic Physical - MarblePhy10] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" Neighborhood [Generic Physical - MarblePhy01] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" [Generic Physical - MarblePhy02] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" [Generic Physical - MarblePhy03] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" [Generic Physical - MarblePhy04] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" [Generic Physical - MarblePhy06] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" [Generic Physical - MarblePhy07] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" [Generic Physical - MarblePhy08] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" Neighborhood2 [Generic Physical - MarblePhy01] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" [Generic Physical - MarblePhy02] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" [Generic Physical - MarblePhy03] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4" [Generic Physical - MarblePhy04] Changed Bounds to kSphereBounds with Radius of "0.75" and Vector of X="0" Y="0" Z="0", Changed Friction to "1" and Mass to "4"
Hazado
force-pushed
the
RoundFiremarbles
branch
from
625b705
to
16a6b08
Compare
|
Based on discussion on discord, this is currently blocking on visual issues with the firemarbles. The ViewFaceModifiers seem to rotate in the "opposite" direction of the physical movement with this change applied. While the marbles tend to roll on a more realistic way with this change, the VFM problem is rather disorienting, so we should not accept until this is corrected. |
|
I don't fully understand what it would take for the VFM issue to be resolved, but this PR will need to be rebased at the very least since there have been Neighborhood and Relto changes in the past 10 months. I imagine it will need to be rebased yet again after all the pending Relto page PRs, too. Or, if it's not likely to be able to be completed any time soon, perhaps this needs to be closed or moved to draft state until someone can pick this back up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the firemarbles in Relto, Neighborhood and Kirel to be actually round.