Restore missing footnote in King Kerath notebook #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on a pre-release version of the notebook that was preserved by the Guild of Archivists (formerly DPWR), the footnotes were slightly changed at some point during development (before the release of ABM). In particular, the first asterisk (next to a Kerath quote) was removed from the text, and the third footnote entry (referencing a Mee-Dis War book) was removed from the footnotes. It appears that these changes were accidental. The removed asterisk doesn't match the removed footnote, and the remaining asterisks and footnotes no longer match up very well with each other. This is most noticeable with the "Taken from Kerath's public speech" footnote: in the pre-release version, it matches up with a Kerath quote, but in the release version, it corresponds to a paragraph about D'ni prophets that doesn't contain anything said by Kerath. This commit re-adds the previously removed asterisk and Mee-Dis War footnote, which restores the footnotes to the more consistent pre-release state. The French and German translations are updated accordingly, with the translation of the footnote copied from other notebooks. The Italian and Spanish translations are *not* updated in this commit, because they are incomplete and don't contain a translation of the Mee-Dis War footnote anywhere. Source: https://archive.guildofarchivists.org/wiki/Reference:DRC_research_notebooks/King_Kerath/2002_DPWR_transcription https://archive.guildofarchivists.org/w/index.php?title=Reference:DRC_research_notebooks/King_Kerath&oldid=1481
Alahmnat said on the OpenUru Discord that this is okay: https://discord.com/channels/282045216221822978/890674263210737665/903900275654406145 |
Hoikas
added
bug
Hoikas
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a pre-release version of the King Kerath notebook that was preserved by the Guild of Archivists (formerly DPWR), the footnotes were slightly changed at some point during development (before the release of ABM). In particular, the first asterisk (next to a Kerath quote) was removed from the text, and the third footnote entry (referencing a Mee-Dis War book) was removed from the footnotes.
It appears that these changes were accidental. The removed asterisk doesn't match the removed footnote, and the remaining asterisks and footnotes no longer match up very well with each other. This is most noticeable with the "Taken from Kerath's public speech" footnote: in the pre-release version, it matches up with a Kerath quote, but in the release version, it corresponds to a paragraph about D'ni prophets that doesn't contain anything said by Kerath.
This commit re-adds the previously removed asterisk and Mee-Dis War footnote, which restores the footnotes to the more consistent pre-release state. The French and German translations are updated accordingly, with the translation of the footnote copied from other notebooks. The Italian and Spanish translations are not updated in this commit, because they are incomplete and don't contain a translation of the Mee-Dis War footnote anywhere.
I'm going to ping the Lore Team on the OpenUru Discord, so that they can look over this and check my reasoning, so that I don't rewrite history in a bad way.