Line endings

[diafero]

Currently, many of the files have Windows line endings (at least those I checked). xKI has mixed line-endings (there's one line with a UNIX line ending), and the Python system files all seem to use UNIX line endings. I suggest to change everything to UNIX line endings within the repo, which is what git usually expects.

However, I am not sure if CWE can properly deal with UNIX line endings in age and SDL files - it should be fixed if it does not.

[diafero]

At https://github.com/diafero/moul-scripts/tree/lineending I pushed a branch with the changes I had in mind. As far as I can tell, everything is still working here.

[dpogue]

Python should definitely be using UNIX line endings, since the compiler doesn't care and git on Windows should automatically convert them (if configured properly).

SDL, age, and fni files are something that will require a bit of testing. I vaguely recall having some sort of problem in PotS due to UNIX line endings in a fni file, but that might have been the result of mixing line endings.
As you say though, if Plasma lacks support for UNIX line endings, that should be fixed ASAP.

[diafero]

Okay, I got a commit ready for the python ones, can I push it? It's of course a rather large commit, so I figured I'd better ask first ;-)

wrt SDL, age, fni: I logged in to MOULa, went to Kadish, pressed some buttons, stared at the fog... it seemed to work all right. I assume something should already have broken if the line endings would not work.
Maybe if the files are encrypted it's a different matter though, since CWE might use fopen(..., "r") which automatically (?) deals with line-endings.

[diafero]

Okay, if nobody objects (as nobody did so far) I'm going to convert the Python line endings to UNIX style this evening.

age, SDL and fni still need testing.

[diafero]

Okay, Python is done.

[Lunanne]

Is this one finished?

[diafero]

I did not do any more work on this, so if nobody else did the age and
fni files still use Windows line endings.

diafero

On 05/11/12 14:41, Anne Marije van der Meer wrote:

Is this one finished?

---

Reply to this email directly or view it on GitHub:
#11 (comment)

[Deledrius]

Closed by #39 .