Fix the chat fade bug... #85
Conversation
|
Haven't tested this, but it looks sane from here. 👍 |
Here's the rub: we were doing entirely too much manual chugging and plugging on the chat fade status, so some corner-cases slipped through. In this case, we absolutely DO NOT WANT to start the fade timer if the user has entered any chat (self.chatMgr.isChatting). We were doing just that any time the chat history display was modified (oops!). See also: - http://forum.guildofwriters.org/viewtopic.php?f=117&t=6076
... The old one was rough like sandpaper and looked like crap. This is much nicer.
|
Kae mentioned some oddity with text shadows and fading. Has anyone reproduced and/or investigated that? |
|
Reproduced consistently, but that bug is beyond the scope of this PR. The fading is done by changing the GUI control's alpha in python and the shadows don't respect this. I assume it's related to the premultiplied alpha stuff? |
|
I’ll take a look when I get around to it (not before the weekend). It sounds very weird because characters and shadows are both just pixels in the same texture, there is no reason why one should be treated differently than the other. |
|
That was my thought as well. Fortunately, this PR makes fixing that issue fairly low-priority. The only observable instance of it now is when the player lists are fading (fortunately, at the end of the animation, that UI item is disabled altogether, so it's not a big deal). |
|
Seems to work fine. 👍 |
... This fixes the bug that many users complained about regarding the chat fading out while they were typing. The issue was that we were inappropriately resetting the fade status anytime the chat buffer changed (someone talked)--thus, fade out. I couldn't throw that away entirely because scrolling the chat buffer should reset the fade state. So, I made a smarter
ResetFadeStatethat checks the chat input state as well. It decreases the general fiddly-ness of managing the fade state.Also, I made the chat fade smoother because it looked nasty before.