Fix json.decoder.JSONDecodeError in extract.py #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent json.decoder.JSONDecodeError from being raised when a match is not loaded correctly, quietly retry until all regex match possibilities are exhausted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago, I started getting
json.decoder.JSONDecodeError, about some sort of unterminated string in pytubeX's internal JSON loading. As I'm no expert in JSON or anything web, I just made this small change that made sureget_ytplayer_configchecks all the patterns inconfig_patternsfor matches before raising an error. This seemed to fix the problem.Edit: This may fix issue #12, not completely sure yet