Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shareable link for each dashboard items #26

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

RihanaE
Copy link
Collaborator

@RihanaE RihanaE commented Jul 4, 2024

No description provided.

@RihanaE RihanaE requested a review from redet-G July 4, 2024 08:13
Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for public-dashboard ready!

Name Link
🔨 Latest commit 3d37822
🔍 Latest deploy log https://app.netlify.com/sites/public-dashboard/deploys/66869a26deff3000080fb4ed
😎 Deploy Preview https://deploy-preview-26--public-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RihanaE
Copy link
Collaborator Author

RihanaE commented Jul 4, 2024

On dashboard 'test2', there are items with an 'undefined' id, which result in being unable to access them. What do we do?

@redet-G
Copy link
Collaborator

redet-G commented Jul 4, 2024

If I remember correctly we have modified the code so that it uses _id property of the dashboard item in such cases.

@redet-G
Copy link
Collaborator

redet-G commented Jul 4, 2024

Additionally, you are still on the #5-adding_support_for_area_chart_type" branch. I am seeing a conflict on chart.js file. It is always advised to create a new feature branch for each of the pull requests and stay in sync with the main branch.

@RihanaE
Copy link
Collaborator Author

RihanaE commented Jul 4, 2024 via email

@redet-G redet-G merged commit 3d579c6 into master Jul 4, 2024
3 of 4 checks passed
@redet-G redet-G deleted the #5-adding_support_for_area_chart_type branch July 4, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants