Skip to content
This repository has been archived by the owner on Apr 18, 2021. It is now read-only.

Give a choice to add Registry or not. #33

Closed
JhChoy opened this issue Dec 31, 2018 · 1 comment
Closed

Give a choice to add Registry or not. #33

JhChoy opened this issue Dec 31, 2018 · 1 comment
Assignees
@JhChoy
Labels
enhancement New feature or request feature: deploy-service

Comments

@JhChoy
Copy link
Contributor

JhChoy commented Dec 31, 2018 •
edited

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior

Always add Registry.

Expected behavior

If someone write a property in service.vvisp.json like

registry: false

Do not add Registry.

Environment


vvisp version: v0.1.9
@JhChoy JhChoy self-assigned this Dec 31, 2018
JhChoy added a commit that referenced this issue Jan 8, 2019
@JhChoy
docs: add information about no-registry #33
f85d14f
JhChoy added a commit that referenced this issue Jan 8, 2019
@JhChoy
feat: add choice to add registry #33
cec2d67
This was referenced Jan 8, 2019
Merged
Closed
JhChoy added a commit that referenced this issue Jan 9, 2019
@JhChoy
docs: add information about no-registry #33
9acce64
JhChoy added a commit that referenced this issue Jan 9, 2019
@JhChoy
feat: add choice to add registry #33
278462b
@JhChoy
Copy link
Contributor Author

JhChoy commented Jan 9, 2019

Closed with #38.
One issue remains at #39.

@JhChoy JhChoy closed this as completed Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JhChoy JhChoy

Labels
enhancement New feature or request feature: deploy-service
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JhChoy