Fix logic for file associations #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move all logic to collect_fieldmaps function - Add metadata checks to make sure that the field map is suitable - Print warnings for mismatches
- Merge ui and workflow logic into collect_events - Do not fail if a single subject is missing event files, only print warning
- May not actually be a problem
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 51.86% 51.95% +0.09%
==========================================
Files 204 206 +2
Lines 10788 10892 +104
Branches 1843 1856 +13
==========================================
+ Hits 5595 5659 +64
- Misses 4822 4854 +32
- Partials 371 379 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.