Fix another performance issue in group stats #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- According to Lindquist et al. <https://doi.org/fzx69f> the chi square distribution with one degree of freedom is not a good null distribution, so the cannot use it for the likelihood ratio test - Also, the `chisq2z_convert` method is quite slow, so this will lead to a big speed up - Also, refactor some code
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
=======================================
Coverage 52.17% 52.18%
=======================================
Files 209 209
Lines 11094 11096 +2
Branches 1903 1903
=======================================
+ Hits 5788 5790 +2
Misses 4919 4919
Partials 387 387
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.