Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with sub- prefixes in FilterResultdicts #264

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

HippocampusGirl
Copy link
Member

Also add regression test

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #264 (cb50afc) into main (8870286) will increase coverage by 0.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   62.19%   62.81%   +0.61%     
==========================================
  Files         218      218              
  Lines       12063    12071       +8     
  Branches     2408     2408              
==========================================
+ Hits         7503     7582      +79     
+ Misses       4114     4029      -85     
- Partials      446      460      +14     
Impacted Files Coverage Δ
halfpipe/interface/resultdict/filter.py 64.57% <100.00%> (+44.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8870286...cb50afc. Read the comment docs.

@HippocampusGirl HippocampusGirl merged commit 212de78 into main Feb 2, 2022
@HippocampusGirl HippocampusGirl deleted the dev/fix/filter branch February 22, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant