Rename some modules for clarity and fix some bugs #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix `mypy` errors and refactor code for readability
- Also fix `mypy` errors - Improve code clarity with more verbose variable names where applicable
- Also fix `mypy` errors - Rename variable and function names for clarity
- Replaces the `Select` interface with something more specific
- Fix imports - Move `collect` methods to `ingest` module
- Change to `fnmatch` introduces named groups, that need to be filtered out from the `groupdict` (python/cpython#19908)
- Until we can switch to a proper library such as textual
Codecov Report
@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 62.81% 58.72% -4.09%
==========================================
Files 218 219 +1
Lines 12071 13740 +1669
Branches 2408 2835 +427
==========================================
+ Hits 7582 8069 +487
- Misses 4029 5178 +1149
- Partials 460 493 +33
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.