Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add super linter #285

Merged
merged 15 commits into from
Mar 6, 2022
Merged

Add super linter #285

merged 15 commits into from
Mar 6, 2022

Conversation

HippocampusGirl
Copy link
Member

No description provided.

@HippocampusGirl HippocampusGirl force-pushed the dev/lint branch 2 times, most recently from de94daa to 0c0919f Compare March 5, 2022 16:57
@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #285 (e106357) into main (f4baab7) will increase coverage by 0.03%.
The diff coverage is 79.71%.

❗ Current head e106357 differs from pull request most recent head 80d8e76. Consider uploading reports for the commit 80d8e76 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
+ Coverage   58.74%   58.77%   +0.03%     
==========================================
  Files         214      215       +1     
  Lines       13726    13766      +40     
  Branches     2838     2839       +1     
==========================================
+ Hits         8063     8091      +28     
- Misses       5169     5179      +10     
- Partials      494      496       +2     
Impacted Files Coverage Δ
halfpipe/interfaces/fixes/applytransforms.py 0.00% <0.00%> (ø)
halfpipe/interfaces/imagemaths/addmeans.py 100.00% <ø> (ø)
halfpipe/interfaces/imagemaths/zscore.py 80.00% <ø> (ø)
halfpipe/logging/formatter.py 86.53% <0.00%> (ø)
halfpipe/logging/worker/writer/__init__.py 100.00% <ø> (ø)
halfpipe/model/model.py 69.81% <ø> (ø)
halfpipe/ui/components/config.py 100.00% <ø> (ø)
halfpipe/ui/components/font.py 100.00% <ø> (ø)
halfpipe/utils/future.py 54.54% <ø> (ø)
halfpipe/utils/image.py 100.00% <ø> (ø)
... and 177 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4baab7...80d8e76. Read the comment docs.

- Use instances instead of static methods
- Fix mypy errors
- Also refactor code for readability and fix mypy errors
@HippocampusGirl HippocampusGirl force-pushed the dev/lint branch 3 times, most recently from 6735b8a to 5c2cef9 Compare March 6, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant