add test for htmlFor to textfield and textarea

HBM · Jan 12, 2017 · a1ccf69 · a1ccf69
1 parent 33db9b7
commit a1ccf69
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/js/textfield/index.js b/src/js/textfield/index.js
@@ -57,7 +57,7 @@ const TextfieldWrapper = ({
   )
 }
 
-export const Textfield = ({float, error, length, ...rest}) => (
+export const Textfield = ({float, error, length, htmlFor, ...rest}) => (
   <TextfieldWrapper
     defaultValue={rest.defaultValue}
     error={error}
@@ -66,7 +66,7 @@ export const Textfield = ({float, error, length, ...rest}) => (
     label={rest.label}
     value={rest.value}
     length={length}
-    htmlFor={rest.htmlFor}
+    htmlFor={htmlFor}
   >
     <input
       className={classnames('Textfield-input', {

diff --git a/src/js/textfield/test/test.js b/src/js/textfield/test/test.js
@@ -85,6 +85,11 @@ describe('Textfield', () => {
     const wrapper = mount(<Textfield type='password' />)
     assert.equal(wrapper.find('.Textfield-input').node.type, 'password')
   })
+
+  it('should allow setting the htmlFor attribute on label element', () => {
+    const wrapper = mount(<Textfield htmlFor='foo' />)
+    assert.equal(wrapper.find('label').node.htmlFor, 'foo')
+  })
 })
 
 describe('Textarea', () => {
@@ -168,5 +173,10 @@ describe('Textarea', () => {
     wrapper.find('textarea').simulate('input', {target})
     assert.equal(target.style.height, '30px')
   })
+
+  it('should allow setting the htmlFor attribute on label element', () => {
+    const wrapper = mount(<Textarea htmlFor='foo' />)
+    assert.equal(wrapper.find('label').node.htmlFor, 'foo')
+  })
 })