Skip to content

Commit

Permalink
Button: refactoring-codet. Button is tag and we inject only our exten…
Browse files Browse the repository at this point in the history
…sions
  • Loading branch information
Fa-So committed Jan 5, 2017
1 parent d748f75 commit b2ade6d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 17 deletions.
10 changes: 5 additions & 5 deletions examples/src/buttonRoute.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,31 +9,31 @@ export default class ButtonRoute extends React.Component {
<div>
<section>
<h2>Button Component</h2>
<Button onClick={e => console.log(e)}>
<Button name='ButtonComponent' onClick={e => console.log(e)}>
Button
</Button>
</section>
<section>
<h2>Filled Button</h2>
<Button filled onClick={e => console.log(e)}>
<Button name='FilledButton' filled onClick={e => console.log(e)}>
Button
</Button>
</section>
<section>
<h2>Raised Button</h2>
<Button onClick={e => console.log(e)} raised>
<Button name='RaisedButton' onClick={e => console.log(e)} raised>
Button
</Button>
</section>
<section>
<h2>Raised & Filled Button</h2>
<Button onClick={e => console.log(e)} raised filled>
<Button name='RaisedFilledButton' onClick={e => console.log(e)} raised filled>
Button
</Button>
</section>
<section>
<h2>Disabled Button</h2>
<Button onClick={e => console.log(e)} disabled>
<Button name='DisabledButton' onClick={e => console.log(e)} disabled>
Button
</Button>
</section>
Expand Down
17 changes: 5 additions & 12 deletions src/js/button/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,35 +2,28 @@
import React from 'react'
import classnames from 'classnames'

const Button = ({disabled, children, className, filled, onClick, raised, type}) => (
const Button = ({children, className, filled, raised, ...rest}) => (
<button
className={classnames('Button', {
'Button--raised': raised,
'Button--filled': filled
}) + ' ' + className}
disabled={disabled}
onClick={onClick}
type={type}
}, `${className}`)}
{...rest}
>
{children}
</button>
)

Button.propTypes = {
className: React.PropTypes.string,
disabled: React.PropTypes.bool,
filled: React.PropTypes.bool,
onClick: React.PropTypes.func,
raised: React.PropTypes.bool,
type: React.PropTypes.oneOf(['submit', 'reset', 'button'])
raised: React.PropTypes.bool
}

Button.defaultProps = {
className: '',
disabled: false,
filled: false,
raised: false,
type: 'button'
raised: false
}

export default Button

0 comments on commit b2ade6d

Please sign in to comment.