Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start using flow #432

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

start using flow #432

wants to merge 7 commits into from

Conversation

zemirco
Copy link
Contributor

@zemirco zemirco commented Feb 19, 2018

  • add flow to the project. first component is the button
  • replace standard with eslint
  • update stylelint and fix all issues

@coveralls
Copy link

coveralls commented Feb 19, 2018

Coverage Status

Coverage increased (+0.003%) to 94.67% when pulling 22f5a9a on flow into d649c08 on master.


[options]

[strict]
Copy link
Collaborator

@Fa-So Fa-So Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ignore]
.*/node_modules/.*/node_modules/md-components

[include]

[libs]

[lints]

[options]

[strict]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in Windows it just works that way

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also activate

[options]
module.use_strict=true
server.max_workers=20

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do those options do? how many workers is default?

@KSchreyer
Copy link
Contributor

It seems that this "flow" pull request gets a bit polluted by the stylelint required CSS changes.
I think, we should focus here on the flow required changes only and pull out the other changes into a separate (stylelint based) pull-request.
Or did I oversee here anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants