Statsdcc <-> statsd compatibility improvements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 10, 2017 11:35
rrusso1982
requested review from
danshoophbo,
zihaoyu,
Jonnymcc,
vasiliyb and
karnatinaresh
Jonnymcc
reviewed
Jun 12, 2017
src/ledger.cc
Outdated
| @@ -168,23 +168,34 @@ void Ledger::process() { | |||
| ++threshold_itr) { | |||
| double pct = | |||
| (*threshold_itr < 0) ? -(*threshold_itr) : (*threshold_itr); | |||
| int num_in_threshold = 0; | |||
There was a problem hiding this comment.
Why make num_in_threshold an int instead of double?
There was a problem hiding this comment.
It's used as an array pointer so it has to be an int to hit an index in the array.
vasiliyb
approved these changes
Jun 12, 2017
| // generate pct name | ||
| char clean_pct[17] = {0}; | ||
| snprintf(clean_pct, sizeof(clean_pct), "upper_%g", pct); | ||
| snprintf(clean_pct, sizeof(clean_pct), "%g", pct); |
There was a problem hiding this comment.
I recall what this was for. This takes the value of pct and injects it into the variable clean_pct with formatting before it get converted to a display value. So this is necessary I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statsdcc is a multi threaded replacement for statsd that is written in c++. It is being tested as a viable replacement for our statsd installation to improve ingestion. Unfortunately statsdcc is not 100% compatible with statsd making is not a "drop-in" replacement for the product. The effort of this PR is to improve the compatibility between statsd and statsdcc.
The implemented improvement are: