Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Pagination Buttons to re-render when server options are changed #251

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mrhammadasif
Copy link
Contributor

Type

What types of changes does your code introduce?
When use ButtonsPagination prop, the buttons Component, doesn't get updated when using serverOptions. Suggested way is to re-render the whole DataTable but it can only be solved by using :key attribute on ButtonsPagination component

It also closed #232

Put an x in the boxes that apply_

  • Fix
  • Feature

Checklist

Put an x in the boxes that apply._

  • Title as described
  • Add unit test by vitest if necessary

Copy link

@zsivhabu zsivhabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses this issue #232

zsivhabu
zsivhabu approved these changes Apr 19, 2023
@likymm
Copy link

likymm commented Sep 3, 2023

is there a chance that this will be merged into production? thanks for the contribution guys

@mrhammadasif
Copy link
Contributor Author

@HC200ok any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Server-side pagination mode, the page number doesn't switch on view.
3 participants