Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HL7.Segment.get_part has wrong typing #39

Open
adkron opened this issue Apr 2, 2024 · 0 comments
Open

HL7.Segment.get_part has wrong typing #39

adkron opened this issue Apr 2, 2024 · 0 comments

Comments

@adkron
Copy link

adkron commented Apr 2, 2024

The typing has pos_integer, but in reality we allow 0 for the field.

Since HL7 is 1 based I don't know if we should change the code to be 1 based or if the typing should be updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adkron