Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active socket, implementation with state machine #68

Merged
merged 48 commits into from
Jul 18, 2023
Merged

Active socket, implementation with state machine #68

merged 48 commits into from
Jul 18, 2023

Commits on Jun 27, 2023

  1. Unit test for detection of disconnected receiver

    @bokner
    bokner committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    5e8b98a View commit details
    Browse the repository at this point in the history

  2. wip

    @bokner
    bokner committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    34f9159 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. wip (6 failing tests, disconnection detection test passed)

    @bokner
    bokner committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    8b6f9ff View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. wip (recv timeout)

    @bokner
    bokner committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    41d0bb9 View commit details
    Browse the repository at this point in the history

  2. Minor

    @bokner
    bokner committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    2552fcf View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2023

  1. Changes to test cases

    @bokner
    bokner committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    613d665 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2023

  1. Store context in state

    @bokner
    bokner committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    69a6530 View commit details
    Browse the repository at this point in the history

  2. Call maybe_close on tcp_error

    @bokner
    bokner committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    29a5056 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Replace some mock tests with real ones

    @bokner
    bokner committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0e76b1f View commit details
    Browse the repository at this point in the history

  2. Make sure socket is invalidated on reconnection

    @bokner
    bokner committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    093767b View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Switching to gen_statem (wip)

    @bokner
    bokner committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    d68353f View commit details
    Browse the repository at this point in the history

  2. Tests passed (except ones for frag responses have to be rewritten)

    @bokner
    bokner committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    14ab8a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Bug fixes, tests for fragmented messages

    @bokner
    bokner committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    472155a View commit details
    Browse the repository at this point in the history

  2. Switching to latest elixir_hl7 breaks the tests

    @bokner
    bokner committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    a1174f4 View commit details
    Browse the repository at this point in the history

  3. Fix some tests

    @bokner
    bokner committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    2daeb38 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Fix flaky test (disconnect on server side could result either in :clo… 

    …sed or :einval depending on timing of send call)
    @bokner
    bokner committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    903d779 View commit details
    Browse the repository at this point in the history

  2. Switch to gen_statem

    @bokner
    bokner committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    ee9e428 View commit details
    Browse the repository at this point in the history

  3. Another flaky test

    @bokner
    bokner committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    43489e5 View commit details
    Browse the repository at this point in the history

  4. Add test for 'one-at-a-time' send request

    @bokner
    bokner committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    295a44e View commit details
    Browse the repository at this point in the history

  5. Restore mix files

    @bokner
    bokner committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    d85d863 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Minor

    @bokner
    bokner committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    2ec626c View commit details
    Browse the repository at this point in the history

  2. Fix flaky test for concurrent sends

    @bokner
    bokner committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    d297c5a View commit details
    Browse the repository at this point in the history

  3. Fix comments to the test case

    @bokner
    bokner committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    1d66ece View commit details
    Browse the repository at this point in the history

  4. Fix comments to the test case

    @bokner
    bokner committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    726cbf7 View commit details
    Browse the repository at this point in the history

  5. Another attempt to fix flaky 'concurrent sends' test

    @bokner
    bokner committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    cbb6c8b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'active_socket' of github.com:bokner/elixir-mllp into ac… 

    …tive_socket

* 'active_socket' of github.com:bokner/elixir-mllp:
  Fix comments to the test case
    @bokner
    bokner committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    e06fc81 View commit details
    Browse the repository at this point in the history

  7. Add 'responses match requests' test for concurrent requests

    @bokner
    bokner committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9b47271 View commit details
    Browse the repository at this point in the history

  8. Update lib/mllp/client.ex 

    Co-authored-by: Bryan Paxton <39971740+starbelly@users.noreply.github.com>
    @bokner @starbelly
    bokner and starbelly committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    1dda940 View commit details
    Browse the repository at this point in the history

  9. Fix TestDispatcher (ask receiver to slow down, if we want it to)

    @bokner
    bokner committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    f95ed7a View commit details
    Browse the repository at this point in the history

  10. Bring the naming in line with :gen_statem (i.e., 'state' refers to FS… 

    …M state, 'data' refers to process state)
    @bokner
    bokner committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    2c2c400 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Use empty string for receive_buffer

    @bokner
    bokner committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    ac37525 View commit details
    Browse the repository at this point in the history

  2. Changes to handle_receive/2 (remove byte_size/1 call; simplify the code)

    @bokner
    bokner committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    e2721d6 View commit details
    Browse the repository at this point in the history

  3. Use iolist for 'receive_buffer'

    @bokner
    bokner committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    00b53bd View commit details
    Browse the repository at this point in the history

  4. Handle 'data after trailer' case

    @bokner
    bokner committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    950d99f View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Fix some assert statements

    @bokner
    bokner committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    d19e13c View commit details
    Browse the repository at this point in the history

  2. Switch backoff tests from mock to real

    @bokner
    bokner committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    cb3ebb4 View commit details
    Browse the repository at this point in the history

  3. Handle trailer being split between packets

    @bokner
    bokner committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    62c9f1f View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Address some review items

    @bokner
    bokner committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    74b735d View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2023

  1. Test for the client accepting requests in 'receiving' state

    @bokner
    bokner committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    d8337ba View commit details
    Browse the repository at this point in the history

  2. Pattern match for trailer_check 

    Co-authored-by: Bryan Paxton <39971740+starbelly@users.noreply.github.com>
    @bokner @starbelly
    bokner and starbelly committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    7280cba View commit details
    Browse the repository at this point in the history

  3. Reset last_byte_received 

    Co-authored-by: Bryan Paxton <39971740+starbelly@users.noreply.github.com>
    @bokner @starbelly
    bokner and starbelly committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    00b0976 View commit details
    Browse the repository at this point in the history

  4. Simplify buffer update

    @bokner
    bokner committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    1912983 View commit details
    Browse the repository at this point in the history

  5. Minor changes to test case

    @bokner
    bokner committed Jul 16, 2023
    Configuration menu
    Copy the full SHA
    a44cf72 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Add 'send_timeout_close' to socket defaults

    @bokner
    bokner committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    0f3ba0a View commit details
    Browse the repository at this point in the history

  2. Shutdown on unexpected packet

    @bokner
    bokner committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    9c6cbf1 View commit details
    Browse the repository at this point in the history

  3. Bug fix: switch to :disconnected if conn has closed

    @bokner
    bokner committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b5db135 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Shutdown socket on receive timeout, if required

    @bokner
    bokner committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    411dae6 View commit details
    Browse the repository at this point in the history

  2. Update cache version

    @bokner
    bokner committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    416f254 View commit details
    Browse the repository at this point in the history