Loosen versioned dependencies. #159
Conversation
| @@ -89,7 +89,7 @@ def txt_read(*paths): | |||
| # requirements | |||
| setup_args['setup_requires'] =\ | |||
| [ | |||
| "setuptools==19.2", | |||
| "setuptools>=19.2", | |||
There was a problem hiding this comment.
The only reason of the '==' is in case of freezing with PyInstaller, otherwise the version can be dropped:
pyinstaller/pyinstaller#1773
Although the PyInstaller ticket is closed, I had to revert to such a version to freeze on OS X.
@jreadey : have you been able to freeze on OS X? Did you need to downgrade to setuptools 19.2?
However, since this bit of info is now in the wiki, I would actually propose to drop the version requirement.
There was a problem hiding this comment.
@ghisvail Have you been able to freeze HDF Compass on your favorite platform?
|
Shall I hold off my packaging effort then? Seems that there is still some uncertainties regarding the dependencies? |
|
I am not sure that I understood. Does the Debian packaging work with the 2 suggested modifications? |
|
I can build with the modifications, indeed. Whether they are loosen or dropped does not matter much on my end. |
|
Can you modify the PR to drop the |
|
so leaving wxpython as is (strict versioning) and dropping setuptools? |
|
@ghisvail For 'setuptools', I would leave it just as dependency, without a specific release. For 'wxPython', since '3.0.2' seems to be the last official release, it does not currently matter. I would be curious to know what is the wxPython release that is available in Debian. @jreadey With such a modification, this PR is fine. Do you need to contact @ghisvail as a contributor? |
|
@ghisvail - this is a pretty trivial change, but if you anticipate making more contributions going forward let me know (and send me your email address), and I'll send you a contributors form to fill out. |
ghisvail
force-pushed
the
fix/versioned-depends
branch
from
6c8323d
to
2f41f9c
Compare
Done
Indeed, this should not require me signing a CLA. |
|
Should we tag a 6.0.0b4? |
|
That would be helpful, thanks. |
We should not require such strict versioned dependencies for setuptools and wxpython. Changing to minimum versions rather than strict ones.