Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDreaddata function in JNI uses mismatched PIN_/UNPIN_ARRAY macros #355

Closed
byrnHDF opened this issue May 9, 2023 · 0 comments
Closed

SDreaddata function in JNI uses mismatched PIN_/UNPIN_ARRAY macros #355

byrnHDF opened this issue May 9, 2023 · 0 comments
Assignees
@byrnHDF
Labels
Component - Java Java wrappers Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Bug Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub

Comments

@byrnHDF
Copy link
Collaborator

byrnHDF commented May 9, 2023 •
edited

HDFGroup/hdfview#119 and HDFGroup/hdfview#120 issues expose a JNI implementation error in the float and double SDreaddata functions.
Both functions were using PIN_xxx_ARRAY_CRITICAL macros to get the data buffers but only used UNPIN_xxx_ARRAY macros to release the buffers. The "CRITICAL" versions should not have been used (the integer versions did not use CRITICAL)
@byrnHDF byrnHDF added Component - Java Java wrappers Type - Bug Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub Priority - 0. Blocker ⛔ This MUST be merged for the release to happen labels May 9, 2023
@byrnHDF byrnHDF self-assigned this May 9, 2023
This was referenced May 9, 2023
Closed
Closed
byrnHDF added a commit to byrnHDF/hdf4 that referenced this issue May 9, 2023
@byrnHDF
Fix GH HDFGroup#355 mismatched macros
faa6871
byrnHDF added a commit to byrnHDF/hdf4 that referenced this issue May 12, 2023
@byrnHDF
Fix GH HDFGroup#355 mismatched macros
4c6c1b0
derobins pushed a commit that referenced this issue May 12, 2023
@byrnHDF
Fix GH #355 mismatched macros (#356)
6a667be
derobins pushed a commit that referenced this issue Jun 5, 2023
@byrnHDF
Fix GH #355 mismatched macros (#358)
70ddec3 
* Fix GH #355 mismatched macros
* codespell fixes
* update exclusions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@byrnHDF byrnHDF

Labels
Component - Java Java wrappers Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Bug Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derobins @byrnHDF