Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed-up building HDF5 #3087

Merged
merged 4 commits into from
Jun 20, 2023
Merged

speed-up building HDF5 #3087

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddc69e6
speed-up building HDF5
brtnfld Jun 9, 2023
7af5940
needs HL
brtnfld Jun 9, 2023
cc67a38
changed check for NetCDF to cron job
brtnfld Jun 9, 2023
6af356f
reverted back to tests with each PR
brtnfld Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/hdfeos5.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Install HDF5
run: |
./autogen.sh
./configure --prefix=/usr/local --with-default-api-version=v16
./configure --prefix=/usr/local --disable-tests --with-default-api-version=v16
make
sudo make install
- name: Install HDF-EOS5
Expand Down
20 changes: 3 additions & 17 deletions .github/workflows/netcdf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,8 @@ name: netCDF

on:
workflow_dispatch:
push:
pull_request:
branches: [ develop ]
paths-ignore:
- '.github/CODEOWNERS'
- '.github/FUNDING.yml'
- 'doc/**'
- 'release_docs/**'
- 'ACKNOWLEDGEMENTS'
- 'COPYING**'
- '**.md'

# Using concurrency to cancel any in-progress job or run
concurrency:
group: ${{ github.workflow }}-${{ github.sha || github.event.pull_request.number }}
cancel-in-progress: true
schedule:
- cron: "6 0 * * *"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If this is going to be tested nightly, we should probably also test HDF-EOS5 nightly
  2. These integration tests take very little time to run. Why not run them on every commit? It's a LOT easier to block bad commits than it is to track people down to revert their changes if a nightly test fails.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted to test with each PR.


jobs:
build:
Expand All @@ -32,7 +18,7 @@ jobs:
- name: Install HDF5
run: |
./autogen.sh
./configure --prefix=/usr/local --disable-static --enable-shared --enable-hl --with-szlib
./configure --prefix=/usr/local --disable-tests --disable-static --enable-shared --enable-hl --with-szlib
make -j
sudo make install -j
- name: Checkout netCDF
Expand Down