Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that the description for system errors may be used by h5py #37

Merged
merged 2 commits into from Oct 15, 2020

Conversation

takluyver
Copy link
Contributor

Following discussion on #34, we decided that this could simply be a comment in the source code. The string format here has been stable for 11 years (since a443284), so hopefully there's no major pressure to change it.

We're just about to release h5py 3.0, so we'll look into getting the errno from the string after that.

@byrnHDF
Copy link
Contributor

byrnHDF commented Oct 15, 2020

I am not disagreeing with the idea, just the content of the message.
I think the specific use of one project, h5py, is the main issue. It should be more general, something like:
/* Other projects may rely on the description format to get the errno and any changes should be considered as an API change */

@takluyver
Copy link
Contributor Author

That makes sense; I've updated the comment.

@qkoziol
Copy link
Contributor

qkoziol commented Oct 15, 2020

Nice!

@lrknox lrknox merged commit e6cda48 into HDFGroup:develop Oct 15, 2020
@takluyver takluyver deleted the description-errno branch October 16, 2020 08:23
@takluyver
Copy link
Contributor Author

Thanks! I am planning to only rely on the errno part. Specifically, we're likely to match it with a regex like errno = (\d+).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants