Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failure on BE with xlf #968

Merged
merged 25 commits into from
Aug 30, 2021
Merged

Fixed failure on BE with xlf #968

merged 25 commits into from
Aug 30, 2021

Conversation

brtnfld
Copy link
Contributor

@brtnfld brtnfld commented Aug 26, 2021

Fixed segfault with xlf on BE with -qintsize=8.

This is a workaround to a compiler bug since the failing test does not get executed when szip is not enabled (which was the failing case). \Just referencing the data_out array anywhere in the code caused a segfault.

@brtnfld brtnfld requested a review from epourmal as a code owner August 26, 2021 21:09
@brtnfld brtnfld requested a review from lrknox August 26, 2021 21:10
@lrknox
Copy link
Collaborator

lrknox commented Aug 27, 2021

passes all tests on echidna with this change.

@byrnHDF
Copy link
Contributor

byrnHDF commented Aug 30, 2021

Release.txt entry needed? Should this be applied to other branches?

@brtnfld
Copy link
Contributor Author

brtnfld commented Aug 30, 2021

This is a test fix, so there is no need for Release.txt; if the other branches fail, it needs to be applied to them.

@lrknox lrknox merged commit 794acf4 into HDFGroup:develop Aug 30, 2021
lrknox added a commit that referenced this pull request Aug 31, 2021
* Committing clang-format changes

* Fixed seg fault with xlf on BE with -qintsize=8

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

Co-authored-by: Scot Breitenfeld <brtnfld@hdfgroup.org>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
lrknox added a commit that referenced this pull request Aug 31, 2021
* Committing clang-format changes

* Fixed seg fault with xlf on BE with -qintsize=8

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

Co-authored-by: Scot Breitenfeld <brtnfld@hdfgroup.org>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
lrknox added a commit that referenced this pull request Aug 31, 2021
* Fixed seg fault with xlf on BE with -qintsize=8

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

Co-authored-by: Scot Breitenfeld <brtnfld@hdfgroup.org>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants