Make bash script prettier

HDFGroup · Nov 28, 2022 · 0ab52cf · 0ab52cf
1 parent 87ca738
commit 0ab52cf
Showing 1 changed file with 23 additions and 22 deletions.
diff --git a/data_stager/test/stage_file.sh b/data_stager/test/stage_file.sh
@@ -1,3 +1,4 @@
+#!/bin/bash
 MPI_EXEC=$1
 HERMES_ROOT=$2
 HERMES_BUILD=$3
@@ -11,27 +12,27 @@ STAGE_OFFSET=$((${STAGE_OFFSET_BLOCKS}*${BLOCK_SIZE}))
 ITER=10
 
 echo "START"
-echo ${MPI_EXEC}
-echo ${HERMES_ROOT}
-echo ${HERMES_BUILD}
-echo ${HERMES_CONF}
+echo "${MPI_EXEC}"
+echo "${HERMES_ROOT}"
+echo "${HERMES_BUILD}"
+echo "${HERMES_CONF}"
 
 mkdir -p /tmp/staging
 mkdir hermes_dir
 
 # Create file
 echo "CREATE FILE"
 ${MPI_EXEC} -n ${N_STAGE} \
-${HERMES_BUILD}/posix_simple_io /tmp/staging/hi.txt 0 ${BLOCK_SIZE_KB} ${ITER} 0 0
+"${HERMES_BUILD}/posix_simple_io" /tmp/staging/hi.txt 0 "${BLOCK_SIZE_KB}" "${ITER}" 0 0
 if [ $? != 0 ]; then
   exit ${RET}
 fi
 
 # Start daemon
 ${MPI_EXEC} -n 1 \
--genv HERMES_CONF ${HERMES_CONF} \
--genv LD_LIBRARY_PATH ${HERMES_BUILD}:$LD_LIBRARY_PATH \
-${HERMES_BUILD}/hermes_daemon &
+-genv HERMES_CONF "${HERMES_CONF}" \
+-genv LD_LIBRARY_PATH "${HERMES_BUILD}:$LD_LIBRARY_PATH" \
+"${HERMES_BUILD}/hermes_daemon" &
 if [ $? != 0 ]; then
   exit ${RET}
 fi
@@ -40,47 +41,47 @@ sleep 1
 
 # Stage file
 echo "STAGE IN"
-${MPI_EXEC} -n ${N_STAGE} \
--genv HERMES_CONF ${HERMES_CONF} \
--genv LD_LIBRARY_PATH ${HERMES_BUILD}:$LD_LIBRARY_PATH \
--genv LSAN_OPTIONS=suppressions=${HERMES_ROOT}/test/data/asan.supp \
+${MPI_EXEC} -n "${N_STAGE}" \
+-genv HERMES_CONF "${HERMES_CONF}" \
+-genv LD_LIBRARY_PATH "${HERMES_BUILD}:$LD_LIBRARY_PATH" \
+-genv LSAN_OPTIONS=suppressions="${HERMES_ROOT}/test/data/asan.supp" \
 -genv SET_PATH=0 \
 -genv HERMES_CLIENT 1 \
-${HERMES_BUILD}/stage_in /tmp/staging/hi.txt ${STAGE_OFFSET} 0 kMinimizeIoTime
+"${HERMES_BUILD}/stage_in" /tmp/staging/hi.txt "${STAGE_OFFSET}" 0 kMinimizeIoTime
 if [ $? != 0 ]; then
   exit ${RET}
 fi
 
 # Read (with hermes)
 echo "READ STAGE IN"
 ${MPI_EXEC} -n ${N_STAGE} \
--genv HERMES_CONF ${HERMES_CONF} \
--genv LD_PRELOAD ${HERMES_BUILD}/libhermes_posix.so \
+-genv HERMES_CONF "${HERMES_CONF}" \
+-genv LD_PRELOAD "${HERMES_BUILD}/libhermes_posix.so" \
 -genv HERMES_STOP_DAEMON 0 \
 -genv ADAPTER_MODE WORKFLOW \
 -genv HERMES_CLIENT 1 \
 -genv HERMES_PAGE_SIZE 1048576 \
-${HERMES_BUILD}/posix_simple_io /tmp/staging/hi.txt 1 ${BLOCK_SIZE_KB} ${ITER} ${STAGE_OFFSET_BLOCKS} 0
+"${HERMES_BUILD}/posix_simple_io" /tmp/staging/hi.txt 1 "${BLOCK_SIZE_KB}" "${ITER}" "${STAGE_OFFSET_BLOCKS}" 0
 if [ $? != 0 ]; then
   exit ${RET}
 fi
 
 # Stage out (with hermes)
 echo "STAGE OUT"
-${MPI_EXEC} -n ${N_STAGE} \
--genv HERMES_CONF ${HERMES_CONF} \
--genv LD_LIBRARY_PATH ${HERMES_BUILD}:$LD_LIBRARY_PATH \
--genv LSAN_OPTIONS=suppressions=${HERMES_ROOT}/test/data/asan.supp \
+${MPI_EXEC} -n "${N_STAGE}" \
+-genv HERMES_CONF "${HERMES_CONF}" \
+-genv LD_LIBRARY_PATH "${HERMES_BUILD}:$LD_LIBRARY_PATH" \
+-genv LSAN_OPTIONS=suppressions="${HERMES_ROOT}/test/data/asan.supp" \
 -genv SET_PATH=0 \
 -genv HERMES_CLIENT 1 \
-${HERMES_BUILD}/stage_out ${HOME}/hi.txt
+"${HERMES_BUILD}/stage_out" "${HOME}/hi.txt"
 if [ $? != 0 ]; then
   exit ${RET}
 fi
 
 # Finalize hermes daemon
 echo "FINALIZE"
-${MPI_EXEC} -n 1 ${HERMES_BUILD}/finalize_hermes
+${MPI_EXEC} -n 1 "${HERMES_BUILD}/finalize_hermes"
 if [ $? != 0 ]; then
   exit ${RET}
 fi