Skip to content

Commit

Permalink
Merge 5817ba0 into d2285f2
Browse files Browse the repository at this point in the history
  • Loading branch information
ChristopherHogan committed Apr 28, 2022
2 parents d2285f2 + 5817ba0 commit 49842ae
Showing 1 changed file with 54 additions and 54 deletions.
108 changes: 54 additions & 54 deletions adapter/test/mpiio/mpiio_adapter_basic_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -990,57 +990,57 @@ TEST_CASE("SingleAsyncRead", "[process=" + std::to_string(info.comm_size) +
posttest();
}

TEST_CASE("SingleAsyncReadCollective",
"[process=" + std::to_string(info.comm_size) +
"]"
"[operation=single_read]"
"[synchronicity=async]"
"[coordination=collective]"
"[request_size=type-fixed][repetition=1]"
"[file=1]") {
pretest();
SECTION("read from non-existing file") {
test::test_open(info.shared_new_file.c_str(), MPI_MODE_RDONLY,
MPI_COMM_WORLD);
REQUIRE(test::status_orig != MPI_SUCCESS);
}

SECTION("read from existing file") {
test::test_open(info.shared_existing_file.c_str(), MPI_MODE_RDONLY,
MPI_COMM_WORLD);
REQUIRE(test::status_orig == MPI_SUCCESS);
test::test_seek(info.rank * args.request_size, MPI_SEEK_SET);
REQUIRE(test::status_orig == 0);
test::test_iread_all(info.read_data.data(), args.request_size, MPI_CHAR);
REQUIRE((size_t)test::size_read_orig == args.request_size);
test::test_close();
REQUIRE(test::status_orig == MPI_SUCCESS);
}

// TODO(chogan): This test fails sporadically.
// https://github.com/HDFGroup/hermes/issues/413
//
// SECTION("read from existing file using shared ptr") {
// test::test_open(info.shared_existing_file.c_str(), MPI_MODE_RDONLY,
// MPI_COMM_WORLD);
// REQUIRE(test::status_orig == MPI_SUCCESS);
// test::test_seek_shared(0, MPI_SEEK_SET);
// REQUIRE(test::status_orig == 0);
// test::test_iread_shared(info.read_data.data(), args.request_size,
// MPI_CHAR);
// REQUIRE((size_t)test::size_read_orig == args.request_size);
// test::test_close();
// REQUIRE(test::status_orig == MPI_SUCCESS);
// }

SECTION("read_at_all from existing file") {
test::test_open(info.existing_file.c_str(), MPI_MODE_RDONLY, MPI_COMM_SELF);
REQUIRE(test::status_orig == MPI_SUCCESS);
test::test_iread_at_all(info.read_data.data(), args.request_size, MPI_CHAR,
info.rank * args.request_size);
REQUIRE((size_t)test::size_read_orig == args.request_size);
test::test_close();
REQUIRE(test::status_orig == MPI_SUCCESS);
}
posttest();
}
// TODO(chogan): This test fails sporadically.
// https://github.com/HDFGroup/hermes/issues/413
// TEST_CASE("SingleAsyncReadCollective",
// "[process=" + std::to_string(info.comm_size) +
// "]"
// "[operation=single_read]"
// "[synchronicity=async]"
// "[coordination=collective]"
// "[request_size=type-fixed][repetition=1]"
// "[file=1]") {
// pretest();
// SECTION("read from non-existing file") {
// test::test_open(info.shared_new_file.c_str(), MPI_MODE_RDONLY,
// MPI_COMM_WORLD);
// REQUIRE(test::status_orig != MPI_SUCCESS);
// }

// SECTION("read from existing file") {
// test::test_open(info.shared_existing_file.c_str(), MPI_MODE_RDONLY,
// MPI_COMM_WORLD);
// REQUIRE(test::status_orig == MPI_SUCCESS);
// test::test_seek(info.rank * args.request_size, MPI_SEEK_SET);
// REQUIRE(test::status_orig == 0);
// test::test_iread_all(info.read_data.data(), args.request_size, MPI_CHAR);
// REQUIRE((size_t)test::size_read_orig == args.request_size);
// test::test_close();
// REQUIRE(test::status_orig == MPI_SUCCESS);
// }

// SECTION("read from existing file using shared ptr") {
// test::test_open(info.shared_existing_file.c_str(), MPI_MODE_RDONLY,
// MPI_COMM_WORLD);
// REQUIRE(test::status_orig == MPI_SUCCESS);
// test::test_seek_shared(0, MPI_SEEK_SET);
// REQUIRE(test::status_orig == 0);
// test::test_iread_shared(info.read_data.data(), args.request_size,
// MPI_CHAR);
// REQUIRE((size_t)test::size_read_orig == args.request_size);
// test::test_close();
// REQUIRE(test::status_orig == MPI_SUCCESS);
// }

// SECTION("read_at_all from existing file") {
// test::test_open(info.existing_file.c_str(), MPI_MODE_RDONLY,
// MPI_COMM_SELF);
// REQUIRE(test::status_orig == MPI_SUCCESS);
// test::test_iread_at_all(info.read_data.data(), args.request_size,
// MPI_CHAR, info.rank * args.request_size);
// REQUIRE((size_t)test::size_read_orig == args.request_size);
// test::test_close();
// REQUIRE(test::status_orig == MPI_SUCCESS);
// }
// posttest();
// }

0 comments on commit 49842ae

Please sign in to comment.