Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for Ares #115

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Bug fixes for Ares #115

merged 1 commit into from
Feb 5, 2021

Conversation

ChristopherHogan
Copy link
Collaborator

  • Hermes cores need RPC clients. Previously just the application cores had them.
  • Converted several RPCs that returned void to return a bool. We don't actually use the result, but it has the effect of making the call synchronous. Previously, when the calls were asynchronous (meaning the caller didn't have to wait for a response), we had an eventual consistency model, so it was possible for a Get to not see metadata that an immediately preceding Put updated. We may switch back to eventual consistency at some point for performance reasons, but right now I prefer deterministic correctness.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 537712821

  • 20 of 54 (37.04%) changed or added relevant lines in 5 files are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 80.216%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/buffer_pool.cc 1 6 16.67%
src/metadata_management.cc 0 14 0.0%
src/rpc_thallium.cc 16 31 51.61%
Files with Coverage Reduction New Missed Lines %
src/buffer_pool.cc 1 78.28%
src/rpc_thallium.cc 15 61.71%
Totals Coverage Status
Change from base Build 522452615: -0.2%
Covered Lines: 4225
Relevant Lines: 5267

💛 - Coveralls

Copy link
Contributor

@jya-kmu jya-kmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it can simplify something at this point it is fine. Yet we may create a bookmark for this change since we expect performance issue in the future especially when scaling.

@ChristopherHogan ChristopherHogan merged commit bacdd58 into master Feb 5, 2021
@ChristopherHogan ChristopherHogan deleted the chogan/ares_fixes branch February 5, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants