Hariharan/cluster test #120
Conversation
- Added Testing exec part of install. - fixed some warning errors. - fixed how file is generated in the test as creating file on pfs directly is expensive. -
Getting latest from Master
Pull Request Test Coverage Report for Build 552378203
💛 - Coveralls |
| size_t offset = abs((int)(((i * rand_r(&info.offset_seed)) | ||
| % info.stride_size) % info.total_size)); |
There was a problem hiding this comment.
You make the same change to the same code in 4 different places in this file. Why not make a helper function size_t GetRandomOffset(size_t i, Info info); so you have this code in one place?
There was a problem hiding this comment.
You define GetRandomOffset four times, which defeats the purpose. Can't you define it just once, pass the seed and stride size as parameters, and use the same function everywhere?
There was a problem hiding this comment.
I created a utility header file where I moved the function and called it from there.
|
I'd prefer if you didn't add new unrelated commits to PRs that are already in the review process. |
The problem is as I have coverage enabled its failing as coverage is reducing. I was fixing that. If you prefer, I can do it on a new PR to improve coverage. |
|
I'm not worried by the failing coverage. I understand that things are in flux right now. You can leave the added coverage commits here, but if you want to increase coverage further, please create a PR specifically for that purpose. |
Sure. I wasn't sure about it. Thanks for clarifying. |
Merge pull request HDFGroup#120 from hariharan-devarajan/hariharan/cluster_test
Changes to ensure test can run on clustered env.