Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hariharan/docker fix #133

Merged

Conversation

hariharan-devarajan
Copy link
Collaborator

This PR fixed the docker image changes required in the master branch

@coveralls
Copy link

coveralls commented Feb 11, 2021

Pull Request Test Coverage Report for Build 581777384

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 55 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.5%) to 81.886%

Files with Coverage Reduction New Missed Lines %
adapter/src/hermes/adapter/interceptor.cc 1 94.12%
adapter/src/hermes/adapter/stdio/stdio.cc 54 85.2%
Totals Coverage Status
Change from base Build 554858765: 1.5%
Covered Lines: 4914
Relevant Lines: 6001

💛 - Coveralls

@hariharan-devarajan hariharan-devarajan self-assigned this Feb 12, 2021
deps.Dockerfile Outdated

RUN . ${SPACK_DIR}/share/spack/setup-env.sh

RUN echo $GITPOD_REPO_ROOT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this leftover from the old image?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yap. FIXED.

Copy link
Member

@gheber gheber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two thumbs (and toes) up!

@hariharan-devarajan hariharan-devarajan merged commit 0f2f2ee into HDFGroup:master Feb 19, 2021
@hariharan-devarajan hariharan-devarajan deleted the hariharan/docker_fix branch March 4, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants