Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control PlacementPolicy at global, Bucket, and Put granularity #167

Merged
merged 6 commits into from
Apr 6, 2021

Conversation

ChristopherHogan
Copy link
Collaborator

Closes #162.

  • Adds a default_placement_policy option to the configuration file. This becomes the default policy value for all instances of api::Context.
  • Save the Context passed to a Bucket. The Context::policy in the Bucket overrides the global default.
  • Add overloads of Put that don't take a Context argument. These versions simply use the Context stored in the Bucket.
  • Passing a Context to a Put overrides the Bucket's default policy.
  • The full Context is preserved on swap blobs when the BO attempts to place them back into the hierarchy. Previously it used a default Context.

@coveralls
Copy link

coveralls commented Apr 2, 2021

Coverage Status

Coverage increased (+0.03%) to 84.958% when pulling e6553f3 on chogan/162 into 9730d23 on master.

Copy link
Contributor

@jya-kmu jya-kmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ChristopherHogan ChristopherHogan merged commit 07f1d78 into master Apr 6, 2021
@ChristopherHogan ChristopherHogan deleted the chogan/162 branch April 6, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable placement policies at the global, Bucket, and Put levels
3 participants