New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in BlobID node assignment #172

Merged

ChristopherHogan merged 1 commit into master from chogan/fix_blob_hash

Apr 16, 2021

Collaborator

ChristopherHogan commented Apr 15, 2021

BlobIDs were being assigned to nodes based on their user-facing name instead of their internal name. All library functions should only operate on the internal name.
Fixed a possible race condition in map iteration. We should only get the number of elements when we already hold the lock.


          Fix bug in BlobID node assignment

6ebba6b

ChristopherHogan requested a review from jya-kmu

April 15, 2021 15:51

coveralls commented Apr 15, 2021

Coverage decreased (-0.5%) to 84.604% when pulling 6ebba6b on chogan/fix_blob_hash into c981906 on master.

jya-kmu approved these changes

View reviewed changes

ChristopherHogan merged commit 9a79e47 into master

ChristopherHogan deleted the chogan/fix_blob_hash branch

April 16, 2021 14:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment