Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes and improvements related to Hermes VPIC proxy #207

Merged
merged 41 commits into from
Jun 25, 2021
Merged

Bug fixes and improvements related to Hermes VPIC proxy #207

merged 41 commits into from
Jun 25, 2021

Conversation

ChristopherHogan
Copy link
Collaborator

  • Adapter client finalization can optionally terminate daemon.
  • RoundRobin DPE algorithm, LocalGetTargets, and GetBandwidths only considers targets with a non-zero number of buffers.
  • Only initialize shared files (e.g., burst buffer files) on one rank.
  • Support configurations with no RAM buffers.
  • Add is_shared_device array to configuration.
  • RoundRobin placement shouldn't fail if the Target list passed to it doesn't contain any instances of the "current" device.
  • Add Hermes::RunDaemon for Hermes daemon programs.
  • Replace gethostbyname with threadsafe version.
  • MPI-IO adapter initialization and finalization only needs to happen in MPI_Init and MPI_Finalize, not when opening and closing files.

@ChristopherHogan
Add initial Hermes version of vpic
8659b52
@ChristopherHogan
VPIC bench arguments
f3c6b8f
@ChristopherHogan
VPIC posix ready for Ares
c11a021
@ChristopherHogan
Add num nodes as input
5bee977
@ChristopherHogan
Add direct io option
6ec9983
@ChristopherHogan
Aligned writes for direct I/O
3c88b5f
@ChristopherHogan
Use global aligned_alloc because Ares has older gcc
0b2a769
@ChristopherHogan
Add flush/sync flag
77d3b21
@ChristopherHogan
Include fsync in timing
608e25c
@ChristopherHogan
Include sync flag in output
2ce66b8
@ChristopherHogan
Update Hermes portion of VPIC
a4e619d
@ChristopherHogan
Running Hermes vpic with all DPE policies
25b3492
@ChristopherHogan
Add sync point
17e6f8b
@ChristopherHogan
More sync
8987ad3
@ChristopherHogan
Add TODOs for bug investigation
72e0cf7
@ChristopherHogan
Add option to pass config path
155dd11
@ChristopherHogan
Sleep between puts
cf5b569
@ChristopherHogan
Calculate RAM buffering capacity based on headers
8087d27
@ChristopherHogan
Allow 0 RAM buffers and don't consider Targets that have no capacity
4f20f9d
@ChristopherHogan
Fixed round robin DPE for case when we have no RAM buffers
4a9c826
@ChristopherHogan
gethostbyname error handling
08ec453
@ChristopherHogan
Use threadsafe version of gethostbyname
cd746c5
@ChristopherHogan
Debugging
d7da627
@ChristopherHogan
Fix finalization for daemon/client case in adapter
8657655
@ChristopherHogan
Silence linter
bda830d
@ChristopherHogan
Update vpic to new spec
9af59bf
@ChristopherHogan
Tweaks for webinar
3d0a0d5
@ChristopherHogan
posix_fallocate is too slow on OrangeFS
9fc825b
@ChristopherHogan
Add is_shared_device option to config
c37b163
@ChristopherHogan
Properly initialize files on shared devices
e75b13d
@coveralls
Copy link

coveralls commented Jun 22, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 83.085% when pulling e54bc29 on chogan/vpic_fixes into 94c864e on master.

jya-kmu
jya-kmu approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@jya-kmu jya-kmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChristopherHogan ChristopherHogan merged commit b0dcc75 into master Jun 25, 2021
@ChristopherHogan ChristopherHogan deleted the chogan/vpic_fixes branch June 25, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jya-kmu jya-kmu jya-kmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChristopherHogan @coveralls @jya-kmu