-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark for VPIC-style workload #231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds changes required for getting the best performance from write-only workloads.
HERMES_PAGE_SIZE
environment variable.rr_retry
toapi::Context
. This is will retry failed round robin placements with the nextTarget
. It mitigates the problem of several ranks doing aPut
where each rank gets a valid schema, but only some of the ranks succeed in getting the buffers. For cases like VPIC where we know we have enough buffering space, we can enable this option to keep trying untilGetBuffers
succeeds.api::Context::disable_swap
. Useful in tandom withrr_retry
.RoundRobinPlacement
now takes asplit
parameter to explicitly enable or disable splitting instead of leaving to random chance. This can be controlled globally via thedefault_rr_split
config variable, or via theapi::Context::rr_split
option.const
.ShutdownBufferOrganizer
. The BO cannot be shutdown via RPC because the RPC servers need to be shut down before the BO (so that there are no outstanding operations in flight).