Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Separate install directory from dependency directory #348

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

ChristopherHogan
Copy link
Collaborator

@ChristopherHogan ChristopherHogan commented Feb 10, 2022

The ~/local directory in CI is cached to speed up the build, so when we make install to that directory the library itself gets cached and future CI runs pick it up when running tests resulting in symbol conflicts. This avoids the problem by installing the library to ~/install. Fixes #342. Coverage had dropped because it was testing an installed library instead of the one just built.

@ChristopherHogan ChristopherHogan added the testing Related to automated testing or CI label Feb 10, 2022
@ChristopherHogan ChristopherHogan self-assigned this Feb 10, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+45.1%) to 81.499% when pulling edcd4eb on chogan/fix_install into 3585dee on master.

@ChristopherHogan ChristopherHogan merged commit f8e9f14 into master Feb 11, 2022
@ChristopherHogan ChristopherHogan deleted the chogan/fix_install branch February 11, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to automated testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate drop in test coverage
2 participants