Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninitialized memory read in VFD #374

Merged
merged 1 commit into from
Mar 17, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions adapter/vfd/H5FDhermes.c
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ H5FD__hermes_open(const char *name, unsigned flags, hid_t fapl_id,
int o_flags; /* Flags for open() call */
struct stat sb;
const H5FD_hermes_fapl_t *fa = NULL;
H5FD_hermes_fapl_t new_fa;
H5FD_hermes_fapl_t new_fa = {0};
char *hermes_config = NULL;
H5FD_t *ret_value = NULL; /* Return value */

Expand Down Expand Up @@ -898,7 +898,6 @@ static herr_t H5FD__hermes_write(H5FD_t *_file, H5FD_mem_t H5_ATTR_UNUSED type,
start_page_index = addr/blob_size;
end_page_index = addr_end/blob_size;

/* Assume only using one page now */
for (k = start_page_index; k <= end_page_index; ++k) {
char k_blob[LEN_BLOB_NAME];
snprintf(k_blob, sizeof(k_blob), "%zu\n", k);
Expand Down