Posix adapter shouldn't rely on O_TMPFILE support #389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernel versions < 3.11 and certain filesystems (e.g., lustre) don't support the
O_TMPFILE
flag toopen
. The flag is used in two ways in the POSIX adapter.open
withO_TMPFILE
like anopen
withO_CREAT
, since both should result in the creation of aBucket
.O_TMPFILE
to test Hermes' handling of the flag.To fix 1), I define
O_TMPFILE
to 0 if it's not defined. To fix 2), I only run theO_TMPFILE
tests after verifying that the kernel and filesystem both supportO_TMPFILE
.